Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerate normals #1

Open
w0rm opened this issue Aug 3, 2020 · 0 comments
Open

Autogenerate normals #1

w0rm opened this issue Aug 3, 2020 · 0 comments

Comments

@w0rm
Copy link
Owner

w0rm commented Aug 3, 2020

This can potentially happen under the hood for Obj.Decode.faces and Obj.Decode.texturedFaces. Right now they would fail if the normals are missing.

Not sure how big of a deal this actually is. One could potentially create an OBJ file that has all the normals in it. In Blender this is as easy as checking “Write Normals” when exporting a file.

If we decide to generate normals in elm-obj-file, we need to consider supporting smoothing groups too. This may increase computational complexity of the code quite a bit. So it might be worth benchmarking loading a file with normals in it and a file where the normals are autogenerated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant