Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Externalink sr-only breaks layout #6

Closed
Mister-Hope opened this issue Feb 20, 2023 · 3 comments · Fixed by #123
Closed

[Bug report] Externalink sr-only breaks layout #6

Mister-Hope opened this issue Feb 20, 2023 · 3 comments · Fixed by #123
Labels

Comments

@Mister-Hope
Copy link
Member

Mister-Hope commented Feb 20, 2023

Description

See https://bornforthis.cn/home.html#_5-%E6%88%91%E7%9A%84%E5%85%A8%E9%83%A8%E5%8D%9A%E5%AE%A2%E5%B9%B3%E5%8F%B0

The page has a table with display: block and overflow-x: scroll, and the table is having long content which it's horizontal scrollable.

If any external link is outside the initial width of page, the external link will break the page layout:

image

The whole page is scrollable

image

If setting display: none to .external-link-icon-sr-only, then the page layout becomes normal again.

I would prefer this is a bug.

Reproduction

Not needed

Used Package Manager

pnpm

System Info

Not related
@Mister-Hope Mister-Hope assigned meteorlxy and unassigned meteorlxy Feb 20, 2023
@Mister-Hope Mister-Hope added the bug Something isn't working label Feb 20, 2023
@Mister-Hope
Copy link
Member Author

cc @meteorlxy Any suggestions on how to solve it?

@Mister-Hope
Copy link
Member Author

Bump here, I have serveral users meeting this issue, mainly with external links in table.

@Mister-Hope
Copy link
Member Author

Any update about this issue, I do not come up with a way to fix this gracefully

@meteorlxy meteorlxy transferred this issue from vuepress/core Dec 3, 2023
@Mister-Hope Mister-Hope linked a pull request May 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants