Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-shiki): code and test refactor #302

Merged
merged 5 commits into from
Dec 13, 2024
Merged

refactor(plugin-shiki): code and test refactor #302

merged 5 commits into from
Dec 13, 2024

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Dec 12, 2024

This avoids errors in unit test:

stderr | plugins/markdown/plugin-shiki/tests/shiki-preWrapper.spec.ts > @vuepress/plugin-shiki > fence preWrapper > :line-numbers / :no-line-numbers > should work properly if `lineNumbers` is enabled by default
[Shiki] 10 instances have been created. Shiki is supposed to be used as a singleton, consider refactoring your code to cache your highlighter instance; Or call `highlighter.dispose()` to release unused instances.

stderr | plugins/markdown/plugin-shiki/tests/shiki-preWrapper.spec.ts > @vuepress/plugin-shiki > fence preWrapper > render whitespace > should work whitespace with `trailing` option
[Shiki] 20 instances have been created. Shiki is supposed to be used as a singleton, consider refactoring your code to cache your highlighter instance; Or call `highlighter.dispose()` to release unused instances.

Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit bb83c99
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/675bd192b506d8000899cb4a
😎 Deploy Preview https://deploy-preview-302--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mister-Hope Mister-Hope merged commit 8acd640 into main Dec 13, 2024
38 checks passed
@Mister-Hope Mister-Hope deleted the shiki branch December 13, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant