Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't collapse template HTML #2234

Closed
dvvdev opened this issue Sep 4, 2020 · 13 comments · Fixed by #2244
Closed

Can't collapse template HTML #2234

dvvdev opened this issue Sep 4, 2020 · 13 comments · Fixed by #2244

Comments

@dvvdev
Copy link

dvvdev commented Sep 4, 2020

  • [X ] I have searched through existing issues
  • [ X] I have read through docs
  • [ X] I have read FAQ

Info

  • Platform: macOS - latest update
  • Vetur version: 2.7.1
  • VS Code version: 1.48.2

Problem

Can't collapse code. The triangles disappear when trying to interact with them.

Reproducible Case

Create code with Vetur 2.7.1. Try to collapse it. Does not work.

Disable Vetur. Collapse code as expected.

Revert to Vetur 2.4 version, code collapses as expected .

@rookie2435
Copy link

me too,hope to solve it as soon as possible.

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 4, 2020

I can't reproducible this, but It's not have collapse in template region.
Are you referring to this?

I think you can edit title to Can't collapse code in template region

@yoyo930021 yoyo930021 added the bug label Sep 4, 2020
@rookie2435
Copy link

yes, I mean this. Thank you for your reply!

@artnova-david
Copy link

same problem. In my case reverting to an older version solves the problem only for .vue files created prior 2.4 version of Vetur.

@antoinematyja
Copy link

On my side this seems to be related with linters. When I open a .vue file, folding works, then one second later unusual linter issues appear and folding disappears.

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 4, 2020

On my side this seems to be related with linters. When I open a .vue file, folding works, then one second later unusual linter issues appear and folding disappears.

It's not what you think.
Provide folding have three ways.
The basic two is Folding Markers and Indentation.
Ths full one is LSP.
ref: #899 (comment)

We try to use LSP for #899 in v0.27.0,
but we forget to add HTML folding in LSP.
We have a PR to fix it now. #2244

PS. The lint error is another problem, but thanks you.

@olearycrew
Copy link

Can't collapse code in template region

This is the correct description of the issue - @dvvdev could you update the title?

@nicovrg
Copy link

nicovrg commented Sep 22, 2020

does someone know when the html folding will be supported again?

@mika76
Copy link

mika76 commented Sep 22, 2020

@nicovrg seems to be working for me... are you on the latest version?

@nicovrg
Copy link

nicovrg commented Sep 22, 2020

i'm on 0.27.0

@CharlesOkwuagwu
Copy link

still not working on version 0.31.3

@yoyo930021
Copy link
Member

still not working on version 0.31.3

Please open a new issue and provide more information.

@davevasquez
Copy link

In case this helps some of you, I was having a similar issue with code folding disappearing a second or two after loading a .vue file. In my case, I had changed the name of the folder where my .vue files were and forgot to update my vetur.config.js file to point to the new directory name. This resulted in disabling my code folding (but as far as I could tell everything else continued to work - which made it hard to pinpoint this as the issue).

Hope this helps someone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.