From b3d1e02b68a1942586ef83a05dd45a9255fa3127 Mon Sep 17 00:00:00 2001 From: Geoffrey Casper Date: Fri, 26 Apr 2024 19:30:07 -0400 Subject: [PATCH] optimize dockerfile --- Dockerfile | 11 ++++------- Dockerfile.dev | 18 ++++++++++++++++++ docker-compose.dev.yml | 5 +++-- 3 files changed, 25 insertions(+), 9 deletions(-) create mode 100644 Dockerfile.dev diff --git a/Dockerfile b/Dockerfile index 33fd2ed..cad0dc5 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,17 +6,14 @@ WORKDIR /home/github/app # Install app dependencies # A wildcard is used to ensure both package.json AND package-lock.json are copied # where available (npm@5+) -# COPY package*.json ./ +COPY package*.json ./ -# RUN npm install --legacy-peer-deps +RUN npm install --legacy-peer-deps # If you are building your code for production # RUN npm ci --only=production -#RUN rm dist - # Bundle app source COPY . . -# RUN npm run build -ENTRYPOINT [ "/home/github/app/start.sh" ] -# CMD [ "bash", "start.sh" ] \ No newline at end of file +RUN npm run build +ENTRYPOINT [ "npm", "run", "start" ] \ No newline at end of file diff --git a/Dockerfile.dev b/Dockerfile.dev new file mode 100644 index 0000000..829424f --- /dev/null +++ b/Dockerfile.dev @@ -0,0 +1,18 @@ +FROM node:16 + +# Create app directory +WORKDIR /home/github/app + +# Install app dependencies +# A wildcard is used to ensure both package.json AND package-lock.json are copied +# where available (npm@5+) +COPY package*.json ./ + +RUN npm install --legacy-peer-deps +# If you are building your code for production +# RUN npm ci --only=production + +# Bundle app source +COPY . . + +ENTRYPOINT [ "npm", "run", "dev" ] \ No newline at end of file diff --git a/docker-compose.dev.yml b/docker-compose.dev.yml index 1fbc611..f0216f1 100644 --- a/docker-compose.dev.yml +++ b/docker-compose.dev.yml @@ -2,7 +2,9 @@ version: "3.3" services: vsc-node: # name of the service - build: . + build: + context: . + dockerfile: Dockerfile.dev image: vsc-node # the image to use container_name: vsc-node_dev # what to label the container for docker ps restart: always # restart if failed, until we stop it ourselves @@ -18,7 +20,6 @@ services: ports: - 1338:1337 environment: - DEV: true IPFS_HOST: http://ipfs:5201 MONGO_HOST: mongo:27017 volumes: