Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for LuxCore.Internal.get_empty_state in KolmogorovArnold.jl #10

Open
chooron opened this issue Dec 19, 2024 · 1 comment
Open

Comments

@chooron
Copy link

chooron commented Dec 19, 2024

Hello, thank you very much for your work in implementing KAN. I am currently looking to integrate the KANs you developed into ModelingToolkit.jl, which requires the representation of equations. The approach I am following is based on ModelingToolkitNeuralNets.jl, where the core idea is to convert the LuxCore.stateless_apply method into equations.

However, after trying this approach, I found that the current version of KolmogorovArnold.jl does not support LuxCore.Internal.get_empty_state, which prevents me from using LuxCore.stateless_apply to convert it into equations. To make this work, and in alignment with the model algorithms, I would like to request that the repository add an interface for LuxCore.Internal.get_empty_state, as follows:

LuxCore.Internal.get_empty_state(l::KDense) = (;grid = collect(LinRange(l.grid_lims..., l.grid_len)))

I am not sure if this method is correct, but I hope you can add support for this method in your future work. Thank you!

@vpuri3
Copy link
Owner

vpuri3 commented Dec 19, 2024

can you create a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants