Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write better acceptance tests for new functionality #185

Open
vinzent opened this issue Jan 17, 2017 · 3 comments
Open

Write better acceptance tests for new functionality #185

vinzent opened this issue Jan 17, 2017 · 3 comments
Assignees
@vinzent
Labels
enhancement New feature or request needs-work not ready to merge just yet
Milestone
1.x.y

Comments

@vinzent
Copy link
Contributor

vinzent commented Jan 17, 2017

Write acceptance tests for #183 , #177, #175, #174
@vinzent vinzent added the enhancement New feature or request label Jan 17, 2017
@vinzent vinzent added this to the 2.0.0 milestone Jan 17, 2017
@vinzent vinzent self-assigned this Jan 17, 2017
@vinzent vinzent added the needs-work not ready to merge just yet label Jan 17, 2017
@oranenj
Copy link
Contributor

oranenj commented Jan 28, 2017

the existing acceptance tests do test a part of the new providers' functionality. In the fcontext case, I extended the test to even check if purging works.

As of this writing, the fcontext and port providers pass acceptance on centos 6 and 7 at least. Presumably Fedora works too.

@oranenj
Copy link
Contributor

oranenj commented Jan 31, 2017

I'm testing with a branch where all three providers have been merged together. Currently successful with CentOS 7.3, and I think I've fixed the remaining issues with CentOS6 as well.

Have to see what happens with Fedora...

@oranenj oranenj modified the milestones: 1.x.y, 1.0.0 Apr 3, 2017
@oranenj
Copy link
Contributor

oranenj commented Apr 3, 2017

So acceptance tests exist, but they might not be complete as complete as they should be, so I'm still keeping this open

@oranenj oranenj changed the title Write acceptance tests for new defined types Write better acceptance tests for new functionality Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinzent vinzent

Labels
enhancement New feature or request needs-work not ready to merge just yet
Projects
None yet
Milestone
1.x.y
Development

No branches or pull requests
2 participants
@oranenj @vinzent