Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate CLI content #48

Open
Baspa opened this issue Oct 10, 2023 · 9 comments
Open

Translate CLI content #48

Baspa opened this issue Oct 10, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Baspa
Copy link
Member

Baspa commented Oct 10, 2023

Only the failure reason is translated for each check, while the check name and other content is not translated. We could translate those as well. We might need help with the French translations.

@Baspa Baspa added enhancement New feature or request help wanted Extra attention is needed labels Oct 10, 2023
@Baspa Baspa self-assigned this Oct 10, 2023
@Baspa
Copy link
Member Author

Baspa commented Oct 10, 2023

@ThibaultDuhem would you like to help me when I'm adding more translations to the translation files? Not all text is currently translated and I would like to add those to the translation files as well.

@ThibaultDuhem
Copy link
Contributor

@Baspa Yes, of course. I'll be happy to assist you with the new translation keys in the french translation file. Just mention me when new keys are available in English, and I'll add them to the French translation file.

@MuriloChianfa
Copy link
Contributor

MuriloChianfa commented Sep 1, 2024

Hello guys, im testing the package and i've noticed that's language not working for me:

image

I had tested tested using language => null and language => 'en', but not work.
Im doing something wrong?

@Baspa
Copy link
Member Author

Baspa commented Sep 2, 2024

My translations work on the latest version (nl and en),

Screenshot 2024-09-02 at 19 23 41 Screenshot 2024-09-02 at 19 24 15

However, titles of the checks are not translated yet (which would be a nice addition). @MuriloChianfa

@MuriloChianfa
Copy link
Contributor

MuriloChianfa commented Sep 2, 2024

Im using the latest version too, but the translations not working :(

Environment Context:
image
image
image

@Baspa
Copy link
Member Author

Baspa commented Sep 3, 2024

Did you also set the locale in your .env file? @MuriloChianfa

@MuriloChianfa
Copy link
Contributor

Testing again here, setting the config app.locale to "en" it works successfully, but my default app.locale is "en_US", that's why it didn't work.

So the config seo.language does not working?
image

@Baspa
Copy link
Member Author

Baspa commented Sep 4, 2024

Hmm I would expect that the language from the seo config would overrule the app config but maybe that's broken. Have to check that to make sure that isn't working. @MuriloChianfa

@Baspa
Copy link
Member Author

Baspa commented Sep 4, 2024

Ah, forgot what the language was used for but I checked it and the language option in the config does only work for the TransitionWordRatioCheck. It checks on transition words on the page and to do so it needs to know the language of the website. @MuriloChianfa

So to change the locale of the output of the scan you should use the normal app config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants