Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSDP] optimizer offload #93

Open
eric-haibin-lin opened this issue Jan 10, 2025 · 0 comments
Open

[FSDP] optimizer offload #93

eric-haibin-lin opened this issue Jan 10, 2025 · 0 comments
Labels
fsdp

Comments

@eric-haibin-lin
Copy link
Collaborator

fsdp optimizer offload will affect the correctness of gradient accumulation. It shall only be enabled if the micro batch size is equal to batch size. verl should add a check to avoid misusage of such kind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fsdp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eric-haibin-lin