Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support different versions of vllm #106

Open
Cppowboy opened this issue Jan 15, 2025 · 5 comments
Open

feature request: support different versions of vllm #106

Cppowboy opened this issue Jan 15, 2025 · 5 comments

Comments

@Cppowboy
Copy link

No description provided.

@vermouth1992
Copy link
Collaborator

Hi,
vllm is currently supporting SPMD-based runner. Once it is merged, verl can fully adopt it without pinning vllm version or modifying vllm any longer.

See

@cgq15
Copy link

cgq15 commented Jan 17, 2025

Seems that it's already merged

@vermouth1992
Copy link
Collaborator

Seems that it's already merged

Yes. We are currently integrating nightly vllm and will release the next version when vllm releases next version.

@SalmanMohammadi
Copy link

Would this mean that verl could be used without Ray, and with torchrun instead?

@vermouth1992
Copy link
Collaborator

vermouth1992 commented Jan 17, 2025

Would this mean that verl could be used without Ray, and with torchrun instead?

Technically yes. But we wouldn't provide this kind of script. Actually, colocating all models together is equivalent to torchrun except ray-based solution also have a single process controller. Directly using torchrun makes extending new functionalities very difficult, especially when involving concurrent running something.

The programming abstraction of verl is called HybridFlow, which combines single controller and multi-controller. Single controller provides flexibility of controling RLHF flows while multi-controller provides high performance computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants