Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer doesn't allow creation of user with no secondary groups #373

Open
tanishyadav opened this issue Mar 1, 2024 · 1 comment
Open
Labels
installer issues and pull requests related to the el cheapo installer

Comments

@tanishyadav
Copy link

validate_useraccount() {
    # don't check that USERNAME has been set because it can be empty
    local USERLOGIN=$(get_option USERLOGIN)
    local USERPASSWORD=$(get_option USERPASSWORD)
    local USERGROUPS=$(get_option USERGROUPS)

    if [ -n "$USERLOGIN" ] && [ -n "$USERPASSWORD" ] && [ -n "$USERGROUPS" ]; then
        USERACCOUNT_DONE=1
    fi
}

The above check (in installer.sh) prevents creation of user without secondary groups. I think USERGROUPS can be left unchecked like USERNAME.

@classabbyamp
Copy link
Member

creating a user with no other groups is inadvisable. you should at minimum have the user be a member of wheel and maybe users

@classabbyamp classabbyamp added the installer issues and pull requests related to the el cheapo installer label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installer issues and pull requests related to the el cheapo installer
Projects
None yet
Development

No branches or pull requests

2 participants