Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: make diagramID optional for diagram model (VF-000) #453

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: make diagramID optional for diagram model (VF-000) #453

wants to merge 1 commit into from

Conversation

viniciusdacal
Copy link
Contributor

@viniciusdacal viniciusdacal commented Sep 19, 2023 •
edited
Loading

Fixes or implements VF-000

Brief description. What is this change?

  • diagramID as required is breaking services that we didn't update yet. To not block people, we are going to make it optional until we update all the services.

@viniciusdacal viniciusdacal self-assigned this Sep 19, 2023
@viniciusdacal
Copy link
Contributor Author

bors r+

bors-vf bot pushed a commit that referenced this pull request Sep 19, 2023
@viniciusdacal
fix: make diagramID optional for diagram model (VF-000) (#453)
300d144 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements VF-000**

### Brief description. What is this change?

- diagramID as required is breaking services that we didn't update yet. To not block people, we are going to make it optional until we update all the services.
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bors-vf
Copy link

bors-vf bot commented Sep 19, 2023

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title fix: make diagramID optional for diagram model (VF-000) [Merged by Bors] - fix: make diagramID optional for diagram model (VF-000) Sep 19, 2023
@bors-vf bors-vf bot closed this Sep 19, 2023
@bors-vf bors-vf bot deleted the vinicius/make-diagram-id-optional/VF-000 branch September 19, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecathectZero DecathectZero DecathectZero approved these changes

Assignees

@viniciusdacal viniciusdacal

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniciusdacal @DecathectZero