From 61528de5050989dd453c2791220660d0b21d35fb Mon Sep 17 00:00:00 2001
From: Le Tan <tamlokveer@gmail.com>
Date: Wed, 29 May 2024 08:10:39 -0700
Subject: [PATCH] remove code signature (#2506)

---
 .github/workflows/ci-macos.yml | 3 +--
 src/CMakeLists.txt             | 1 +
 src/CPackMacDeployQt.cmake.in  | 5 ++++-
 src/data/core/Info.plist       | 2 ++
 4 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci-macos.yml b/.github/workflows/ci-macos.yml
index 64bdd65ec4..c8551badd9 100644
--- a/.github/workflows/ci-macos.yml
+++ b/.github/workflows/ci-macos.yml
@@ -51,7 +51,6 @@ jobs:
           brew install tree libiodbc libpq
 
       - name: Fix SQL
-        if: ${{matrix.config.arch == 'universal'}}
         run: |
           sudo mkdir -p /usr/local/opt/libiodbc/lib
           sudo ln -s /opt/homebrew/opt/libiodbc/lib/libiodbc.2.dylib /usr/local/opt/libiodbc/lib/libiodbc.2.dylib
@@ -103,7 +102,7 @@ jobs:
           cmake --build . --target pack
           ls -ls .
           ls -ls src
-          mv src/vnote.dmg VNote-${{env.VNOTE_VER}}-mac-${{matrix.config.arch}}.dmg
+          mv src/VNote.dmg VNote-${{env.VNOTE_VER}}-mac-${{matrix.config.arch}}.dmg
         working-directory: ${{runner.workspace}}/build
 
       # Enable tmate debugging of manually-triggered workflows if the input option was provided
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index c275efe951..b51ea17a46 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -131,6 +131,7 @@ elseif(APPLE)
     # The generated Info.plist will be overridden.
     set_target_properties(vnote
         PROPERTIES
+        OUTPUT_NAME "${PROJECT_NAME}"
         MACOSX_BUNDLE_BUNDLE_NAME "${PROJECT_NAME}"
         MACOSX_BUNDLE_INFO_STRING "${PROJECT_DESCRIPTION}"
         MACOSX_BUNDLE_GUI_IDENTIFIER "fun.vnote.app"
diff --git a/src/CPackMacDeployQt.cmake.in b/src/CPackMacDeployQt.cmake.in
index dde001a2b3..890a1b54fb 100644
--- a/src/CPackMacDeployQt.cmake.in
+++ b/src/CPackMacDeployQt.cmake.in
@@ -1,4 +1,7 @@
-execute_process(COMMAND "${MACDEPLOYQT_EXECUTABLE}" ${CMAKE_CURRENT_BINARY_DIR}/vnote.app -dmg
+execute_process(COMMAND "codesign" --remove-signature ${CMAKE_CURRENT_BINARY_DIR}/VNote.app
+    WORKING_DIRECTORY ${CPACK_PACKAGE_DIRECTORY}
+)
+execute_process(COMMAND "${MACDEPLOYQT_EXECUTABLE}" ${CMAKE_CURRENT_BINARY_DIR}/VNote.app -dmg
     -always-overwrite -verbose=1
     WORKING_DIRECTORY ${CPACK_PACKAGE_DIRECTORY}
 )
diff --git a/src/data/core/Info.plist b/src/data/core/Info.plist
index 7f39ee999d..86e7f45678 100644
--- a/src/data/core/Info.plist
+++ b/src/data/core/Info.plist
@@ -18,6 +18,8 @@
             </array>
         </dict>
     </array>
+    <key>com.apple.security.cs.disable-library-validation</key>
+    <true/>
     <key>CFBundleName</key>
     <string>VNote</string>
     <key>CFBundleExecutable</key>