Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GitHub Auth Secret #8

Open
curran opened this issue Oct 29, 2018 · 0 comments
Open

Remove GitHub Auth Secret #8

curran opened this issue Oct 29, 2018 · 0 comments
Labels
1 Weight of 1 tech debt Technical debt

Comments

@curran
Copy link
Contributor

curran commented Oct 29, 2018

This should not be open https://github.com/datavis-tech/vizhub/blob/master/packages/web/server/next-auth.providers.js#L5

No security risk now as this client secret has been reset, but there should be none defined in the code at all.

@curran curran added 1 Weight of 1 tech debt Technical debt labels Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Weight of 1 tech debt Technical debt
Projects
None yet
Development

No branches or pull requests

1 participant