New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp & Modernize #15

Open

curran opened this issue Jul 30, 2019 · 0 comments

Collaborator

curran commented Jul 30, 2019 •

edited

Loading

This library does a cool thing, but there are some remnants from the past baked in that I think we can remove. Namely:

the jQuery workaround
Coffeescript files support
url.replace('blob://', 'http://')

Not sure if this might warrant a new library, as it would break a lot of the older bl.ocks in Blockbuilder.

See also https://gist.github.com/benjamingr/0433b52559ad61f6746be786525e97e8

Not sure how this is different https://github.com/vizhub-core/vizhub/blob/d31eafef8998555eaaa5ec0d654b604ce619bea7/vizhub-v2/packages/presenters/src/magicSandbox.js

Ideally this would support images as well

Should support P5 loading.https://vizhub.com/curran/84640b3b30a84c17b464b745daa8e0fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment