diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java index e0164ca6de..11b79883d4 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/BaseEditController.java @@ -38,7 +38,10 @@ public class BaseEditController extends VitroHttpServlet { - public static final boolean FORCE_NEW = true; // when you know you're starting a new edit process + public static final String ENTITY_URI_ATTRIBUTE_NAME = "_permissionsEntityURI"; + public static final String ENTITY_TYPE_ATTRIBUTE_NAME = "_permissionsEntityType"; + + public static final boolean FORCE_NEW = true; // when you know you're starting a new edit process public static final String JSP_PREFIX = "/templates/edit/specific/"; @@ -205,7 +208,7 @@ public String getDefaultLandingPage(HttpServletRequest request) { protected static void addAccessAttributes(HttpServletRequest req, String entityURI, AccessObjectType aot) { // Add the permissionsEntityURI (if we are creating a new property, this will be empty) - req.setAttribute("_permissionsEntityURI", entityURI); + req.setAttribute(ENTITY_URI_ATTRIBUTE_NAME, entityURI); // Get the available permission sets List permissionSets = buildListOfSelectableRoles(ModelAccess.on(req).getWebappDaoFactory()); diff --git a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java index cb96b514f0..c8120dd7ef 100644 --- a/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java +++ b/api/src/main/java/edu/cornell/mannlib/vedit/controller/OperationController.java @@ -135,14 +135,14 @@ public void doPost (HttpServletRequest request, HttpServletResponse response) { // If contains restrictions if (request.getParameter("_permissions") != null) { // Get the namespace that we are editing - String entityUri = request.getParameter("_permissionsEntityURI"); + String entityUri = request.getParameter(ENTITY_URI_ATTRIBUTE_NAME); if (StringUtils.isEmpty(entityUri)) { // If we don't have a namespace set, we are creating a new entity so use that namespace if (!StringUtils.isEmpty(request.getParameter("Namespace")) && !StringUtils.isEmpty(request.getParameter("LocalName"))) { entityUri = "" + request.getParameter("Namespace") + request.getParameter("LocalName"); } } - String entityType = request.getParameter("_permissionsEntityType"); + String entityType = request.getParameter(ENTITY_TYPE_ATTRIBUTE_NAME); List permissionSets = buildListOfSelectableRoles(ModelAccess.on(request).getWebappDaoFactory()); List roleUris = new ArrayList<>(); for (PermissionSet permissionSet : permissionSets) { diff --git a/webapp/src/main/webapp/templates/edit/specific/dataprop_retry.jsp b/webapp/src/main/webapp/templates/edit/specific/dataprop_retry.jsp index 08757afb9e..959828b2ca 100644 --- a/webapp/src/main/webapp/templates/edit/specific/dataprop_retry.jsp +++ b/webapp/src/main/webapp/templates/edit/specific/dataprop_retry.jsp @@ -3,6 +3,9 @@ <%@ taglib prefix="form" uri="http://vitro.mannlib.cornell.edu/edit/tags" %> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> <%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions"%> + + + <%-- colspan set to 4 in DatapropRetryController.java --%> @@ -126,8 +129,8 @@ - - + + Display permissions for this property
diff --git a/webapp/src/main/webapp/templates/edit/specific/fauxProperty_retry.jsp b/webapp/src/main/webapp/templates/edit/specific/fauxProperty_retry.jsp index 3f6ce4160e..2d864f27c7 100644 --- a/webapp/src/main/webapp/templates/edit/specific/fauxProperty_retry.jsp +++ b/webapp/src/main/webapp/templates/edit/specific/fauxProperty_retry.jsp @@ -4,6 +4,8 @@ <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> <%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions"%> + + Base property
@@ -63,8 +65,8 @@ - - + + Display permissions for this property
diff --git a/webapp/src/main/webapp/templates/edit/specific/property_retry.jsp b/webapp/src/main/webapp/templates/edit/specific/property_retry.jsp index 22d8486aa7..19da776ae2 100644 --- a/webapp/src/main/webapp/templates/edit/specific/property_retry.jsp +++ b/webapp/src/main/webapp/templates/edit/specific/property_retry.jsp @@ -4,6 +4,8 @@ <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> <%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions"%> + + <%-- colspan set to 6 in PropertyRetryController.java --%> @@ -190,8 +192,8 @@ - - + + Display permissions for this property
diff --git a/webapp/src/main/webapp/templates/edit/specific/vclass_retry.jsp b/webapp/src/main/webapp/templates/edit/specific/vclass_retry.jsp index 6a567472f5..307815ad40 100644 --- a/webapp/src/main/webapp/templates/edit/specific/vclass_retry.jsp +++ b/webapp/src/main/webapp/templates/edit/specific/vclass_retry.jsp @@ -6,6 +6,8 @@ <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> <%@ taglib prefix="fn" uri="http://java.sun.com/jsp/jstl/functions"%> + + Class label
@@ -88,8 +90,8 @@ - - + + Display permissions for this property