Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print "no tests found" in HTML reporter #7256

Open
6 tasks done
sheremet-va opened this issue Jan 15, 2025 · 5 comments
Open
6 tasks done

Print "no tests found" in HTML reporter #7256

sheremet-va opened this issue Jan 15, 2025 · 5 comments
Labels
feat: ui Vitest UI p3-minor-bug An edge case that only affects very specific usage (priority)

Comments

@sheremet-va
Copy link
Member

Describe the bug

This is a follow up issue to #7246

If there are no tests, HTML reporter is generated, but it looks "stuck" (border move like it's awaiting something).

We need to print "no tests found" instead.

Reproduction

https://stackblitz.com/fork/github/vitest-dev/vitest/tree/main/examples/basic?initialPath=__vitest__/

System Info

Any

Used Package Manager

pnpm

Validations

@sheremet-va sheremet-va added feat: ui Vitest UI p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 15, 2025
@DevJoaoLopes
Copy link
Contributor

@sheremet-va Just to understand, here the intention would be to remove the counters by inserting a message ? Would you need to keep the sidebar ?

Image

@hi-ogawa
Copy link
Contributor

@DevJoaoLopes We probably don't have to remove anything as long it's clear that Vitest is finished by not finding any test. Note that current UI is indicating something is on-going by moving the top border.

@DevJoaoLopes
Copy link
Contributor

@DevJoaoLopes We probably don't have to remove anything as long it's clear that Vitest is finished by not finding any test. Note that current UI is indicating something is on-going by moving the top border.

@hi-ogawa I understood, so in the case just removing the top edge indication and adding the "No test found" message below the counters would solve the problem?

@hi-ogawa
Copy link
Contributor

hi-ogawa commented Jan 20, 2025

@DevJoaoLopes Probably that works. Exact UI can be fleshed out later and starting with something minimal should help the review process.

@sheremet-va
Copy link
Member Author

There is already code for displaying errors. We just need to display this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ui Vitest UI p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

No branches or pull requests

3 participants