Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only generating webmanifest (without service worker) as strategy #815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jnoordsij
Copy link

Description

This PR aims to add a very simple webManifestOnly strategy to the plugin, which does not generate a service worker at all. This is useful for very minimal setups, which want to generate just a webmanifest file (possibly with additional assets generated through the assets-generator plugin).

Linked Issues

N/A

Additional Context


Tip

The author of this PR can publish a preview release by commenting /publish below.

Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit e4a3c75
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/6790d6d4caf5ee0008fe4a19
😎 Deploy Preview https://deploy-preview-815--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin
Copy link
Member

userquin commented Jan 22, 2025

To check the webmanifest you only need to add the plugin with empty options (the plugin will add some entries from the package.json), just enable dev options and test it in private browsing.

I think this can be done also adding a manifest.json to public folder and registering the manifest link in the head, adding also this entry to the manifest.json file, and disabling the manifest (manifest: false) in the pwa options if plugin registered:

{
  "$schema": "https://json.schemastore.org/web-manifest-combined.json"
}

The problem is about checking the new strategy here and all integrations when can be done on the user land, right now I'm very busy but will keep this PR open, be patient 🙏.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants