Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dir option missing 'auto' support #807

Open
gvillo opened this issue Dec 13, 2024 · 1 comment
Open

dir option missing 'auto' support #807

gvillo opened this issue Dec 13, 2024 · 1 comment

Comments

@gvillo
Copy link

gvillo commented Dec 13, 2024

Hi! I found out that in manifest dir option is missing auto, source: https://docs.pwabuilder.com/#/builder/manifest?id=dir-string

    /**
     * @default `ltr`
     */
    dir: 'ltr' | 'rtl';

Auto will detect it based on text content

@userquin
Copy link
Member

You can omit that entry in the PWA plugin options, the default value is not set here https://github.com/vite-pwa/vite-plugin-pwa/blob/main/src/options.ts#L105-L113 : manifest entry is declared as manifest: Partial<ManifestOptions> | false, we'll need to update the jsdocs.

Anyway, we need to add auto there and change the default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants