Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest entries doesn't respect basePath #59

Open
AntoineMontane opened this issue Jan 18, 2025 · 0 comments · May be fixed by #60
Open

manifest entries doesn't respect basePath #59

AntoineMontane opened this issue Jan 18, 2025 · 0 comments · May be fixed by #60

Comments

@AntoineMontane
Copy link

When building manifest entries with a basePath different from root, icons src are relative instead of absolute, which prevent the browser to load the correct file. src field should be set from icon url and not icon name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(manifest): fix icon src when manifest is not a the root AntoineMontane/vite-pwa-assets-generator
1 participant
@AntoineMontane