Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XO Updated #47

Closed
ZyC0R3 opened this issue Mar 28, 2020 · 3 comments
Closed

XO Updated #47

ZyC0R3 opened this issue Mar 28, 2020 · 3 comments

Comments

@ZyC0R3
Copy link

ZyC0R3 commented Mar 28, 2020

XO has been updated from the version this API is currently using 0.16.0 to 0.28.1

in V0.18.0 it added in 21 new rules: (https://github.com/xojs/xo/releases/tag/v0.18.0)
Unicorn plugin: sindresorhus/[email protected]
no-array-instanceof
no-new-buffer
no-hex-escape
number-literal-case
escape-case
prefer-starts-ends-with
custom-error-definition
type-error
AVA plugin: avajs/eslint-plugin-ava@a0156f1
no-async-fn-without-await
no-duplicate-modifiers

When you update this dependency to 0.28.0 or even past 0.17.0 it breaks the testing in travis, but the api still works in the deployment i use, is there anyway you will be able to update the XO Dependancy and the test to use the latest version.

@vitalets
Copy link
Owner

vitalets commented May 1, 2020

could you make a PR with latest XO version and make tests passing?

@ZyC0R3
Copy link
Author

ZyC0R3 commented Jul 18, 2020

I can not seem to fix this issue or get the tests to pass. Are you able to fix this.

@vitalets
Copy link
Owner

vitalets commented Nov 3, 2022

In new release v9 XO was replaced with eslint.

@vitalets vitalets closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants