Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with useControl when upgrading to nextjs 14.2 #2413

Open
amplicity opened this issue Jul 8, 2024 · 0 comments
Open

Issues with useControl when upgrading to nextjs 14.2 #2413

amplicity opened this issue Jul 8, 2024 · 0 comments
Labels

Comments

@amplicity
Copy link

amplicity commented Jul 8, 2024

Description

I'm using an implementation that can be summed up as the following

<Map
        initialViewState={initialViewState}
        style={{ width: '100%', height: '100%' }}
        mapStyle="mapbox://styles/mapbox/satellite-streets-v12"
      >
        <DrawControl
          position="top-left"
          onCreate={onUpdate}
          onUpdate={onUpdate}
          onDelete={onDelete}
        />
</Map>

Where DrawControl looks something like...

import MapboxDraw from '@mapbox/mapbox-gl-draw';
import { useControl } from 'react-map-gl';

export default function DrawControl({
  onCreate = () => {},
  onUpdate = () => {},
  onDelete = () => {},
  ...props
}: DrawControlProps) {
  const [draw, setDraw] = useState<MapboxDraw | null>(null);
  useControl<MapboxDraw>(
    () => {
      const drawInstance = new MapboxDraw(props);
      setDraw(drawInstance);
      return drawInstance;
    },
    ({ map }) => {
      map.on('draw.create', onCreate);
      map.on('draw.update', onUpdate);
      map.on('draw.delete', onDelete);
    },
    ({ map }) => {
      map.off('draw.create', onCreate);
      map.off('draw.update', onUpdate);
      map.off('draw.delete', onDelete);
    },
    {
      position: props.position,
    }
  );

  useEffect(() => {
    if (!draw || !mapReady) return;
    const currentDrawings = draw.getAll();
}, [draw, someOtherVariableWeTrack]

We haven't had any issues with this implementation until upgrading to next 14.2. I've downgraded back to next 14.1 and confirmed that the issue is selective to next 14.2 for reasons I'm still trying to understand. The error I get is that draw.getAll() is undefined. Upon debugging, I can see that draw is indeed defined, along with some non-function attributes, but all the functions yield the same undefined error.

I have confirmed that this behavior happens even after the map is definitively loaded. I now have high confidence the issue is with the way I am storing drawInstance. From other posts online, it seems like this issue happens when the map is not yet loaded. However, I can confirm that the map is loaded and the draw control is present -- I can draw polygons on the map with no issues, but whenever I hit this useEffect, I always get the error, even once the map is loaded and I can confirm the ability to draw.

This is what leads me to believe it is something related to the way useControl is working, or at the very least is something related to the way that we're referencing the drawInstance.

Expected Behavior

In next 14.1, this works as expected. The expected behavior is to have access to the drawings that are currently on the map.

Steps to Reproduce

Can provide codesandbox if the description is not enough to understand the issue. Please let me know.

Environment

Logs

TypeError: Cannot read properties of undefined (reading 'getAll')
    at e.getAll (mapbox-gl-draw.js:1:77757)
    at eval (draw-control.tsx:50:34)
    at commitHookEffectListMount (react-dom.development.js:21102:1)
    at commitHookPassiveMountEffects (react-dom.development.js:23154:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23259:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23334:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23370:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
    at commitPassiveMountOnFiber (react-dom.development.js:23256:1)
    at recursivelyTraversePassiveMountEffects (react-dom.development.js:23237:1)
@amplicity amplicity added the bug label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant