Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site reloads each time a new page is clicked on. Would love to fix that with react-router #1133

Open
Psalmuel01 opened this issue Oct 25, 2023 · 10 comments
Assignees

Comments

@Psalmuel01
Copy link

I'd love to use react-router to make it a single page application and enable seamless transition between the home page and about page for example, without needing to reloading over and over.

@vikhyatsingh123
Copy link
Owner

@Psalmuel01 sure

@Psalmuel01
Copy link
Author

On it.

@Psalmuel01
Copy link
Author

just realized the project is not a react app. do you mind converting it all into one

@vikhyatsingh123
Copy link
Owner

if you can convert it into react, please I will be happy to merge it

@Psalmuel01
Copy link
Author

yes, i can, but it will be a breaking change. and the whole mode of adding an hero/villain will have to change. i'mma wait till ther'es no more contributions in view to effect it. give me a go ahead when/if ready

@vikhyatsingh123
Copy link
Owner

now, you can start working on it. there will be no more change

@Psalmuel01
Copy link
Author

Psalmuel01 commented Nov 2, 2023

okay
please stop merging pull requests for now

@vikhyatsingh123
Copy link
Owner

@Psalmuel01 are you working on it or not?

@Psalmuel01
Copy link
Author

hey, so sorry for the delay
already started working on it, but got caught up on work
will continue as soon as i get free

@vikhyatsingh123
Copy link
Owner

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants