From eabcdf0d6d8584cc969a32fc4f7dcbb7263b5886 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mads=20M=C3=B8ller?= <info@viezel.dk>
Date: Tue, 20 Oct 2020 13:33:59 +0200
Subject: [PATCH] return types

---
 src/Controllers/API/CreateWebhook.php     | 3 ++-
 src/Controllers/API/DeleteWebhook.php     | 3 ++-
 src/Controllers/API/ListWebhookEvents.php | 3 ++-
 src/Jobs/WebhookCall.php                  | 2 +-
 src/Listener/WebhookListener.php          | 2 +-
 src/Requests/CreateWebhookRequest.php     | 4 ++--
 src/Support/GeneratesIds.php              | 8 ++++----
 src/WebhooksServiceProvider.php           | 2 +-
 8 files changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/Controllers/API/CreateWebhook.php b/src/Controllers/API/CreateWebhook.php
index c0ca597..441e1af 100644
--- a/src/Controllers/API/CreateWebhook.php
+++ b/src/Controllers/API/CreateWebhook.php
@@ -6,6 +6,7 @@
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Routing\Controller;
 use Illuminate\Support\Facades\Response;
 use Viezel\Webhooks\Models\Webhook;
@@ -17,7 +18,7 @@ class CreateWebhook extends Controller
     use DispatchesJobs;
     use ValidatesRequests;
 
-    public function __invoke(CreateWebhookRequest $request)
+    public function __invoke(CreateWebhookRequest $request): JsonResponse
     {
         $hook = Webhook::create($request->validated());
 
diff --git a/src/Controllers/API/DeleteWebhook.php b/src/Controllers/API/DeleteWebhook.php
index 87f38e2..bad8fac 100644
--- a/src/Controllers/API/DeleteWebhook.php
+++ b/src/Controllers/API/DeleteWebhook.php
@@ -6,6 +6,7 @@
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Routing\Controller;
 use Illuminate\Support\Facades\Response;
 use Viezel\Webhooks\Models\Webhook;
@@ -16,7 +17,7 @@ class DeleteWebhook extends Controller
     use DispatchesJobs;
     use ValidatesRequests;
 
-    public function __invoke(string $id)
+    public function __invoke(string $id): JsonResponse
     {
         Webhook::findOrFail($id)->delete();
 
diff --git a/src/Controllers/API/ListWebhookEvents.php b/src/Controllers/API/ListWebhookEvents.php
index 25c4fe0..560cb48 100644
--- a/src/Controllers/API/ListWebhookEvents.php
+++ b/src/Controllers/API/ListWebhookEvents.php
@@ -6,6 +6,7 @@
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
+use Illuminate\Http\JsonResponse;
 use Illuminate\Routing\Controller;
 use Illuminate\Support\Facades\Response;
 use Viezel\Webhooks\WebhookRegistry;
@@ -16,7 +17,7 @@ class ListWebhookEvents extends Controller
     use DispatchesJobs;
     use ValidatesRequests;
 
-    public function __invoke()
+    public function __invoke(): JsonResponse
     {
         return Response::json(WebhookRegistry::allEvents());
     }
diff --git a/src/Jobs/WebhookCall.php b/src/Jobs/WebhookCall.php
index 61fb054..c1611ce 100644
--- a/src/Jobs/WebhookCall.php
+++ b/src/Jobs/WebhookCall.php
@@ -30,7 +30,7 @@ public function __construct(Webhook $webhook, array $payload)
         $this->payload = $payload;
     }
 
-    public function handle()
+    public function handle(): void
     {
         Http::timeout(10)
             //->retry(3, 60)
diff --git a/src/Listener/WebhookListener.php b/src/Listener/WebhookListener.php
index 9e456f0..4a4333d 100644
--- a/src/Listener/WebhookListener.php
+++ b/src/Listener/WebhookListener.php
@@ -8,7 +8,7 @@
 
 class WebhookListener
 {
-    public function handle(ShouldDeliverWebhooks $event)
+    public function handle(ShouldDeliverWebhooks $event): void
     {
         Webhook::trigger($event->getWebhookName(), $event->getWebhookPayload());
     }
diff --git a/src/Requests/CreateWebhookRequest.php b/src/Requests/CreateWebhookRequest.php
index 75ce683..76a5469 100644
--- a/src/Requests/CreateWebhookRequest.php
+++ b/src/Requests/CreateWebhookRequest.php
@@ -9,12 +9,12 @@
 
 class CreateWebhookRequest extends FormRequest
 {
-    public function authorize()
+    public function authorize(): bool
     {
         return true;
     }
 
-    public function rules()
+    public function rules(): array
     {
         return [
             'events' => ['required', 'array'],
diff --git a/src/Support/GeneratesIds.php b/src/Support/GeneratesIds.php
index dff51f1..cedae8f 100644
--- a/src/Support/GeneratesIds.php
+++ b/src/Support/GeneratesIds.php
@@ -7,7 +7,7 @@
 
 trait GeneratesIds
 {
-    public static function bootGeneratesIds()
+    public static function bootGeneratesIds(): void
     {
         static::creating(function (self $model) {
             if (! $model->getKey()) {
@@ -16,17 +16,17 @@ public static function bootGeneratesIds()
         });
     }
 
-    public function getIncrementing()
+    public function getIncrementing(): bool
     {
         return false;
     }
 
-    public function getKeyType()
+    public function getKeyType(): string
     {
         return 'string';
     }
 
-    public function getIdAttribute($value)
+    public function getIdAttribute($value): string
     {
         return (string) $value;
     }
diff --git a/src/WebhooksServiceProvider.php b/src/WebhooksServiceProvider.php
index b90dbf2..83bc0ea 100644
--- a/src/WebhooksServiceProvider.php
+++ b/src/WebhooksServiceProvider.php
@@ -7,7 +7,7 @@
 
 class WebhooksServiceProvider extends ServiceProvider
 {
-    public function boot()
+    public function boot(): void
     {
         if ($this->app->runningInConsole()) {
             $migrationFileName = 'create_webhooks_table.php';