Sweetening the syntactic sugar for the where clause (FieldsWhere)

[jayasuryat]

The syntactic sugar provided by the contacts.core.util.FieldsWhere.kt can be boiled down into only two functions using Kotlin's operator fun invoke overload.

These two methods seem enough to the job so far :

inline operator fun <T : Field> T.invoke(
    where: T.() -> Where<T>,
): Where<T> = where(this)

inline operator fun <T : Field, FS : FieldSet<T>> FS.invoke(
    where: FS.() -> Where<T>,
): Where<T> = where(this)

Checked against the example given in the Readme file, and it is working fine.

val contacts = Contacts(context)
    .query()
    .where {
        (Name.GivenName startsWith "leo") and
        (Email.Address { endsWith("gmail.com") or endsWith("hotmail.com") }) and
        (Address.Country equalToIgnoreCase "us") and
        (Event { (Date lessThan Date().toWhereString()) and (Type equalTo EventEntity.Type.BIRTHDAY) }) and
        (Contact.Options.Starred equalTo true) and
        (Nickname.Name equalTo "DarEdEvil") and
        (Organization.Company `in` listOf("facebook", "FB")) and
        (Note.Note.isNotNullOrEmpty())
    }
    .accounts(
        Account("[email protected]", "com.google"),
        Account("[email protected]", "com.myspace"),
    )
    .include { setOf(
        Contact.Id,
        Contact.DisplayNamePrimary,
        Phone.Number
    ) }
    .orderBy(ContactsFields.DisplayNamePrimary.desc())
    .offset(0)
    .limit(5)
    .find()

Would like to know your opinion on this approach, and are there any more cases to consider?

[vestrel00]

@jayasuryat, I just tried it out... IT IS GENIUS MY FRIEND!!! PURE GENIUS!!! 🤯 🤯 🤯 🤯 🤯 🤯 🤯

I just tried it out and it works perfectly! I It's so much better than my current implementation because...

1. It is 2 lines of code versus mine which is around 500 lines of code 🤯 !!!
2. It does not require updating when fields/fieldsets are added, modified, or removed.
3. The code autocomplete popup suggestions by Android Studio is much, much cleaner now!

I have reopened issue #150 and assigned it to you. Please delete the entire contacts.core.util.FieldsWhere.kt file and add your two functions in contacts.core.Where =)

I will be awarding you a gold medal in Reddit once it is merged!!!

This Reddit comment; https://www.reddit.com/r/Kotlin/comments/rtxfdm/comment/hr19srb/?utm_source=share&utm_medium=web2x&context=3

[jayasuryat]

Sure thing @vestrel00, I'll take up the issue and add these methods as top-level methods in the contacts.core.Where file.

And thank you so much for your kind words, I really appreciate you taking the time to express that.

[vestrel00]

@jayasuryat, I merged your PR! I also left a comment on it; #163 (comment)

Thanks again =)