WebClient should use the Address specified in RequestOptions #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs #2574 to be merged for tests to pass |
tsegismont
added a commit
to tsegismont/vertx-service-resolver
that referenced
this pull request
Feb 9, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-service-resolver
that referenced
this pull request
Feb 9, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-service-resolver
that referenced
this pull request
Feb 9, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
Fixes vert-x3#2571 Without this fix, we can't integrate the Vert.x Web Client and the Vert.x Service Resolver. Signed-off-by: Thomas Segismont <[email protected]>
Otherwise, the shared client test does not pass because a client still exists with the wrong configuration. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
force-pushed
the
issue/2571
branch
from
012922e to
f99587c
Compare
|
Tests pass successfully now |
tsegismont
added a commit
to tsegismont/vertx-service-resolver
that referenced
this pull request
Feb 12, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-service-resolver
that referenced
this pull request
Feb 14, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
vietj
approved these changes
Feb 15, 2024
tsegismont
added a commit
to eclipse-vertx/vertx-service-resolver
that referenced
this pull request
Mar 7, 2024
Related to vert-x3/vertx-web#2573 Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2571
Without this fix, we can't integrate the Vert.x Web Client and the Vert.x Service Resolver.