Intermittent test failures in Healthcheck tests and StaticHandlerTest #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix vert-x3#2551 In StaticHandlerTest, some tests create alternative http servers. We must make sure the original and the replacement servers are closed properly. Otherwise, the test results may be affected by the test execution order. In HealthCheckTestBase, we make sure the client, the server and the Vert.x server are closed properly, and in this order. Signed-off-by: Thomas Segismont <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2551
In StaticHandlerTest, some tests create alternative http servers. We must make sure the original and the replacement servers are closed properly. Otherwise, the test results may be affected by the test execution order.
In HealthCheckTestBase, we make sure the client, the server and the Vert.x server are closed properly, and in this order.