Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review SingleSelect Implementation #64

Open
jallers opened this issue May 10, 2019 · 0 comments
Open

Review SingleSelect Implementation #64

jallers opened this issue May 10, 2019 · 0 comments

Comments

@jallers
Copy link
Contributor

jallers commented May 10, 2019

I would like to review some implementation changes to SingleSelect that alters both how consumers work with the component.

SingleSelect should focus on being a text input way of filtering a list of options. A dropdown or select without a text input should belong to a different component.

SingleSelect should be more opinionated about how to render a set of options, potentially deferring to the consumer to produce the DOM for the individual options, but producing a wrapper and potentially default implementation of the render.

I think the relationship between menu and list is confusing and makes reasoning about the performance harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant