Save events no firing (v3)

[KevinJump]

When you save something with a handler it should trigger a save of the item to disk, for v3 this doesn't appear to be happening.

its not a major deal, if people are running and export or syncing via uSync.Complete but it should be there so we can keep in sync.

for example the PaymentMethodHandler should handle PaymentMethodSavedNotification and PaymentMethodDeletedNotification
but it doesn't fire.

guessing because we never actually register these via an EventHub?

but ?

All the handlers are in a collection that is loaded via uSync
We are implimenting IEventHandlerFor so i am not sure how we register them

    public class PaymentMethodHandler : VendrSyncHandlerBase<PaymentMethodReadOnly>, ISyncVendrHandler
        , IEventHandlerFor<PaymentMethodSavedNotification>
        , IEventHandlerFor<PaymentMethodDeletedNotification>

Guess it is a quick thing but not sure what it requires ?

[mattbrailsford]

There should be some registrations register in a composer. See here for some docs on this https://vendr.net/docs/core/3.0.0/key-concepts/events/#registering-a-validation-event-handler

Looks like we do it an older way in Vendr.Deploy but this was probably for ease when we were targeting older versions https://github.com/vendrhub/vendr-deploy/blob/v3/main/src/Vendr.Deploy/Composing/VendrDeployComponent.cs#L133 but it at least lists what we should be handling

I’ll take a look on Monday though