Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted entities included in export #18

Open
philipdanielhayton opened this issue Nov 10, 2022 · 2 comments
Open

Deleted entities included in export #18

philipdanielhayton opened this issue Nov 10, 2022 · 2 comments

Comments

@philipdanielhayton
Copy link

Hi Matt,

I'm getting a null reference error when deploying local changes to a new environment in Umbraco Cloud. I've traced it back to a Vendr Currency UDA that contains references to countries that have been soft deleted (as in, I deleted them in Umbraco but they still have rows in the DB).

To repeat this issue you need to:

  1. Create a new country
  2. Create a new currency
  3. Add the new country as an allowed country to the new currency
  4. Delete the new country
  5. Re-run the export
  6. Inspect the UDA file, it should contain a reference to the deleted country even though the country is no longer shown as allowed within Umbraco / Vendr.
  7. If you then try to deploy that change, the target environment will throw a null reference error
@philipdanielhayton
Copy link
Author

Just to confirm that hard deleting the redundant currencies manually in the DB and re-running the export has fixed the issue.

@mattbrailsford
Copy link
Member

Hmm, interesting.

We have event handlers registered in Vendr that when a country is deleted, it should remove itself from all currencies as an allowed country so that shouldn't be able to happen.

I'll have to take a look at why that might be occuring 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants