Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default selection events work on mobile #4661

Closed
kanitw opened this issue Mar 5, 2019 · 8 comments
Closed

Make default selection events work on mobile #4661

kanitw opened this issue Mar 5, 2019 · 8 comments
Labels
Area - Interaction P2 Important Issues that should be fixed soon
Milestone

Comments

@kanitw
Copy link
Member

kanitw commented Mar 5, 2019

Currently, our default selection events are only for desktop applications.

@kanitw kanitw added Help wanted 🙏 P2 Important Issues that should be fixed soon labels Mar 5, 2019
@kanitw kanitw added this to the x.x Interaction Patches milestone Mar 5, 2019
@domoritz domoritz marked this as a duplicate of #4208 Mar 6, 2019
@domoritz domoritz closed this as completed Mar 6, 2019
@kanitw kanitw reopened this Mar 6, 2019
@domoritz
Copy link
Member

@mattijn showed how you can add touch interactions to VL right now in #4208 (comment) but we should see how we can support this by default.

@vega vega deleted a comment from domoritz Mar 31, 2019
@vega vega deleted a comment from domoritz Mar 31, 2019
@vega vega deleted a comment from domoritz Mar 31, 2019
@kanitw
Copy link
Member Author

kanitw commented Mar 31, 2019

@domoritz said that Falcon has some example events that work on mobile too.

@luciodale
Copy link

Is there any progress on this feature? :)

@domoritz
Copy link
Member

domoritz commented May 1, 2019

Not yet but we would be thrilled about PRs along those lines.

@kanitw kanitw modified the milestones: x.x Interaction Patches, 4.0 Jun 6, 2019
@kanitw kanitw modified the milestones: 4.0, 4.0? (Maybe in 4.0) Jun 26, 2019
@kanitw kanitw assigned donghaoren and unassigned sirahd Oct 15, 2019
@donghaoren
Copy link
Contributor

@domoritz, I'd love to give this a try, could you point me to the Falcon code that handles mobile events?

@domoritz
Copy link
Member

It's all in https://github.com/uwdata/falcon/blob/master/src/views/histogram.ts. You can try Falcon on your phone or iPad as well: https://uwdata.github.io/falcon/flights/.

@keckelt
Copy link
Contributor

keckelt commented Jan 29, 2020

Suggestion from my side:

  • Single selection: tap
  • Multi selection: tap to select, tap again to deselect, i.e. like with toggle set to true
  • 1D Interval: the ones from Falcon (I came here to see if the falcon brush is planned to become default 🙂 )
  • 2D Interval: 🤷‍♂ the grabbers fromfalcon will not work if the selected area is small, but I'm not sure if there is a reasonable alternative

Falcon brush:
falcon

@domoritz
Copy link
Member

domoritz commented Oct 4, 2023

Done in #9089

@domoritz domoritz closed this as completed Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Interaction P2 Important Issues that should be fixed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants