Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appending remote PADES signatures #235

Open
arvinjarvin opened this issue Mar 13, 2024 · 5 comments
Open

Appending remote PADES signatures #235

arvinjarvin opened this issue Mar 13, 2024 · 5 comments
Labels

Comments

@arvinjarvin
Copy link

Hi

Hope you're well

Wondering how I can append a remote PADES signature with your library, which is a base64 returned by an external signing service.

@vbuch
Copy link
Owner

vbuch commented Mar 13, 2024

Hi,
You would need to implement a Signer. The package only has one such implementation currently - https://github.com/vbuch/node-signpdf/blob/develop/packages/signer-p12/src/P12Signer.js but as you can see the abstract is quite simple https://github.com/vbuch/node-signpdf/blob/develop/packages/utils/src/Signer.js#L4

@vbuch vbuch added the question label Mar 13, 2024
@arvinjarvin
Copy link
Author

Thank you.

I'll get back on this issue if any more Qs.

@arvinjarvin
Copy link
Author

Is the buffer being returned a buffer of the signed hash, or of the whole PDF integrating the signed hash?

@vbuch
Copy link
Owner

vbuch commented Mar 13, 2024

It's the signature only. It will be used here: https://github.com/vbuch/node-signpdf/blob/develop/packages/signpdf/src/signpdf.js#L79
The idea is that @signpdf/signpdf will deal with the PDF part. The Signer should only care of crypto.

@vbuch
Copy link
Owner

vbuch commented Mar 13, 2024

You should probably have a look at #230
You didn't say what the external signing service would be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants