Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping local usage of {{ .Release.Name }} in mounts, container names, etc. #28

Open
sirn opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@sirn
Copy link
Collaborator

sirn commented Oct 23, 2024

This is a relic of the past, and makes adding an additional sidecar containers harder than it should be, as everything now requires templating if it needs to reference to existing volumes (e.g. VSM):

extraVolumeMounts: |
  - name: {{ .Release.Name }}-vsm
    # ...

As doing {{ .Release.Name }} here and elsewhere in a Pod (e.g. container name) doesn't have any real gains, we should consider dropping it.

Since we want to avoid breaking existing deploy, a possible migration strategy might be to add server.nameFromReleaseName with the default set to true for the time being, which retains current behavior with a deprecation message, then switch to false sometimes in the future, and eventually drop the server.nameFromReleaseName/{{ .Release.Name }} usage altogether.

@sirn sirn added the enhancement New feature or request label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant