Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

The addon information "settingsPermission" is wrong #298

Open
R-J opened this issue Jul 31, 2018 · 0 comments
Open

The addon information "settingsPermission" is wrong #298

R-J opened this issue Jul 31, 2018 · 0 comments

Comments

@R-J
Copy link
Contributor

R-J commented Jul 31, 2018

The "settingsPermission" is totally useless. The permission isn't checked anywhere and I personally only use it as a) a reminder that I shouldn't forget permission checks and b) to show in the information which permissions I will require later on for the settings.

There has been a discussion some time before: https://open.vanillaforums.com/discussion/comment/243084#Comment_243084

But now this option is described in the docs without a warning and a false text. The addon quickstart shows this text:

To create a “Settings” button that will appear on the addon after it is enabled, add these to your definition:

And that is followed by the required "settingsUrl" and the useless "settingsPermission"

The Addon Info page is even more dangerously describing this key as

The permission required to access the addon’s settings page.

I think that key should be named since it is used a lot but with a warning that using it has no effect at all.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant