New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make helper to validate basic configuration variables #576

Open

solarw opened this issue Feb 15, 2023 · 0 comments

Labels

Collaborator

solarw commented Feb 15, 2023

open-aea/aea/helpers/dependency_tree.py

Line 236 in 5fd694b

public_id = PublicId.from_json(item_config)

in this line, PublicID constructed from json data, that was not validated

propose:

create utility function to load package config and calidate author, name, version, aea version and other mandatory fields for package configuration.
do not load configuration manualy, use utility function proposed above.

solarw mentioned this issue

small validation error message formatting fix #575

Merged

22 tasks

DavidMinarsch added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment