Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Pearl icons is default Electron icon #307

Closed
truemiller opened this issue Aug 30, 2024 · 1 comment · Fixed by #335
Closed

Windows Pearl icons is default Electron icon #307

truemiller opened this issue Aug 30, 2024 · 1 comment · Fixed by #335
Assignees
@truemiller
Labels
severity: low

Comments

@truemiller
Copy link
Collaborator

truemiller commented Aug 30, 2024 •
edited
Loading

image

Need to ensure Windows icon is set in Electron build script.
Currently only Mac config has this defined.
image

Next steps
@truemiller truemiller self-assigned this Aug 30, 2024
@truemiller truemiller changed the title Windows Pearl icon is default Electron icon Windows Pearl icons is default Electron icon Aug 30, 2024
@oaksprout oaksprout mentioned this issue Sep 3, 2024
Open
10 tasks
@truemiller truemiller linked a pull request Sep 20, 2024 that will close this issue
feat: staging to main #335
Merged
@truemiller
Copy link
Collaborator Author

truemiller commented Sep 20, 2024 •
edited
Loading

was fixed in #335
6e33a9a#diff-2dbb20d72aafa780f5b49f1ffd86b632b132d4da90bf5dac41b2d3a7d308f22eR35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@truemiller truemiller

Labels
severity: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: staging to main valory-xyz/olas-operate-app
1 participant
@truemiller