Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let challenger observe all of the transcript #74

Open
morganthomas opened this issue Oct 29, 2023 · 1 comment
Open

Let challenger observe all of the transcript #74

morganthomas opened this issue Oct 29, 2023 · 1 comment

Comments

@morganthomas
Copy link
Collaborator

The challenger for the Fiat-Shamir transformation needs to observe all of the pieces which are in the transcript. Otherwise, soundness bugs can result. See derive/src/lib.rs, where there are some relevant TODO comments. Review the use of the challenger to make sure that the Fiat-Shamir transformation is being performed properly, adding any observations to it as needed.

@morganthomas
Copy link
Collaborator Author

The challenger should also observe a digest of all constraints & trace lengths, according to a comment by Daniel Lubarov in the implementation of verify in derive/src/lib.rs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant