Loading ELF files #138
Merged
Loading ELF files #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thealmarty
reviewed
Apr 8, 2024
morganthomas
force-pushed
the
morgan/issue/135
branch
from
ef90d59
to
ad8faea
Compare
thealmarty
reviewed
Apr 8, 2024
| && section_header.sh_flags == (abi::SHF_ALLOC | abi::SHF_WRITE).into(); | ||
| let is_text: bool = section_header.sh_type == abi::SHT_PROGBITS | ||
| && section_header.sh_flags == (abi::SHF_ALLOC | abi::SHF_EXECINSTR).into(); | ||
| let is_useful: bool = is_data || is_bss || is_text; |
There was a problem hiding this comment.
I don't think this is needed. I've removed this in https://github.com/valida-xyz/valida/pull/145/files and confirmed it works.
thealmarty
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
I've fix some warnings and remove is_useful in https://github.com/valida-xyz/valida/pull/145/files. Please merge that before merging this if you are fine with that. Thanks!
|
Thanks @thealmarty ! The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #135