Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basis set orbitals are not linked to atoms in a structure #2

Open
hatemhelal opened this issue Sep 23, 2024 · 0 comments
Open

Basis set orbitals are not linked to atoms in a structure #2

hatemhelal opened this issue Sep 23, 2024 · 0 comments
Assignees

Comments

@hatemhelal
Copy link
Member

At the point where we create each atomic orbital we effectively copy the center from each atom to use within the orbital instance. This effectively disconnects the orbitals from being associated with a particular atom and presents a few problems:

  • autodiff with respect to atomic positions doesn't work out of the box
  • associating orbitals with atomic level labels requires an additional mapping to be defined

One solution might be to use an atom id instead of using the atom center when creating the orbital instances.

@hatemhelal hatemhelal self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant