Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken images in Granite #279

Open
aggsol opened this issue Mar 12, 2020 · 4 comments
Open

Broken images in Granite #279

aggsol opened this issue Mar 12, 2020 · 4 comments

Comments

@aggsol
Copy link

aggsol commented Mar 12, 2020

Describe the bug
Image from Granite are not display in Firefox 74 due to errors

To Reproduce

  1. Goto https://valadoc.org/granite/Granite.Widgets.ModeButton.html
  2. See missing image
  3. Open image in new Tab (https://valadoc.org/granite/img/ModeButton.png)
  4. See error message

Expected behavior
Images are displayed in Browser
error

Desktop

  • Firefox 74, Windows 10
@ricotz
Copy link
Member

ricotz commented Mar 13, 2020

Duplicate of #281

@ricotz ricotz marked this as a duplicate of #281 Mar 13, 2020
@aggsol
Copy link
Author

aggsol commented Mar 16, 2020

@ricotz While #281 is indeed fixed. The broken images in Granite are still there.

@ricotz
Copy link
Member

ricotz commented Mar 16, 2020

@aggsol Yeah this is a different issue.

@ricotz ricotz marked this as not a duplicate of #281 Mar 16, 2020
@benwaffle
Copy link
Member

looks like the "image" is actually the contents of the HTML file - the github page for https://github.com/elementary/granite/blob/master/doc/images/ModeButton.png

Maybe a URL somewhere needs to be updated to https://raw.githubusercontent.com/elementary/granite/master/doc/images/ModeButton.png ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants