feat: add mixin for handling partial i18n objects #8558
Conversation
|
| * localization, replace this with an object that provides all properties, or | ||
| * just the individual properties you want to change. | ||
| */ | ||
| i18n: DeepPartial<I>; |
There was a problem hiding this comment.
This is a change for Typescript users in that the following would not compile anymore:
const i18n: DatePickerI18n = datePicker.i18n;Seems kind of niche?.
OTOH other common use cases like the following should still work:
datePicker.i18n = { ...(new DatePicker().i18n), months: [...] };Another option to applying the deep partial type in the mixin could be to apply it to the respective I18N type in each component, so if someone would import DatePickerI18n for example, they would already get a partial type. That could also make it easier for type-checks in application code that wants to use a partial object in some state. For example, the following would not compile with the current solution, but would compile if we changed DatePickerI18n to be partial itself.
const i18n = useSignal<DatePickerI18n>({ months: [...] })
Adds a mixin for handling partial I18N objects in components:
i18nproperty.i18nproperty it is possible to provide a partial I18N object. The mixin will then do a deep merge of the default properties with the custom properties to ensure that the effective I18N object has a value for every property.__effectiveI18nproperty internally.The benefits would be:
i18nproperty.