Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking session / authorization in the urls posted in new comment bodies #649

Open
darraghoriordan opened this issue Apr 14, 2023 · 3 comments
Open

Leaking session / authorization in the urls posted in new comment bodies #649

darraghoriordan opened this issue Apr 14, 2023 · 3 comments

Comments

@darraghoriordan
Copy link

darraghoriordan commented Apr 14, 2023 •
edited
Loading

Hey,

It looks like the link that is posted in new issue bodies leaks the session of the first commenter?

I can click on that link, and if the person is still logged in to github via utterances, i can post a comment as them.

The link that the bot creates for issue bodies should not include the "utterances=" query string containing the session??
@darraghoriordan
Copy link
Author

image

That link should not have the "utterances=" query param

@darraghoriordan darraghoriordan mentioned this issue Apr 14, 2023
Open
@darraghoriordan darraghoriordan changed the title Leaking session authentication in the urls posted in new comment bodies Leaking session / authorization in the urls posted in new comment bodies Apr 14, 2023
@yiyb0603
Copy link

Did you solve problem? I have still issue too.

@darraghoriordan
Copy link
Author

Did you solve problem? I have still issue too.

Hey, I didn't. I just removed it from my site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darraghoriordan @yiyb0603