Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation with examples using JSON #26

Open
2 tasks
froehlichcr opened this issue Jun 1, 2021 · 2 comments
Open
2 tasks

Update documentation with examples using JSON #26

froehlichcr opened this issue Jun 1, 2021 · 2 comments
Labels
chore Tasks, chores, non-development work
Milestone

Comments

@froehlichcr
Copy link
Contributor

@froehlichcr froehlichcr added the chore Tasks, chores, non-development work label Jun 1, 2021
@froehlichcr froehlichcr added this to the 1.0 Release milestone Jun 1, 2021
@TomNUSDS
Copy link
Collaborator

TomNUSDS commented Jun 2, 2021

I put this common on the wrong issue? Making it again here:

@mchelen-gov pointed out that syntax like ageCalc: (birthday) => !isFraCalculator(birthday, 12) is particularly problematic for json.

@froehlichcr
Copy link
Contributor Author

I put this common on the wrong issue? Making it again here:

@mchelen-gov pointed out that syntax like ageCalc: (birthday) => !isFraCalculator(birthday, 12) is particularly problematic for json.

Yes, the consumer will have to supply the function if required. This is already done in the complex storybook example. If a consumer wants to apply a calculator, they will need to do it client side after the bulk of the JSON has been applied.

@froehlichcr froehlichcr modified the milestones: 1.2 Release, 1.3 Release Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Tasks, chores, non-development work
Projects
None yet
Development

No branches or pull requests

2 participants