Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: Follow/Notes updates to My Grants #3601

Open
ClaireValdivia opened this issue Oct 8, 2024 · 5 comments
Open

[Issue]: Follow/Notes updates to My Grants #3601

ClaireValdivia opened this issue Oct 8, 2024 · 5 comments
Assignees
Labels
Grant Finder Issues related to the Grant Finder

Comments

@ClaireValdivia
Copy link
Contributor

ClaireValdivia commented Oct 8, 2024

Why is this issue important?

We want the My Grants tab to reflect the new activity introduced with Follow & Notes

Current State

On the My Grants page, there are currently four "tabs" across the top to filter the grants that display in the table:

  • Shared With Your Team - shows any grants shared with your team
  • Interested - shows grants that the user has marked as one of the Interested statuses
  • Not Applying - shows grants that the user has marked as one of the Not Applying statuses
  • Applied - shows grants that the user has marked as one of the Applied statuses

Expected State

  • "Shared With Your Team" should be updated to "Shared With My Team" and will display the same grants it currently does (i.e. any grants shared with your team)
  • A new tab will be created that is called "Followed by My Team" - this should be a filtered list of all grants currently followed by the user and/or any other user in their team.
  • The current tabs for Interested, Not Applying, Applied should be removed
  • The grants table column "Interested Teams" should be renamed "Followed By"
  • Both "Followed by" and "Viewed by" should display the full team name if any user in the user's team has followed the grant (rather than current state of showing abbreviation). Team name text should wrap if needed.
  • If more than one team member follows or views a grant, the team name should only appear once in the respective column
  • If other teams view or follow the grant, all team names where someone follows the grant should display in comma separated list (i.e. US Digital Response, State of Nevada, Department of Education)
  • Export to CSV - the exported file should reflect the renamed column of "Followed By", and the full team name(s) should display in a comma separated list for both Viewed by and Followed by.

Image

Implementation Plan

Use the followNotesEnabled feature flag - #3405

  • Add new tab to MyGrantsView, including new instance of GrantsTable and adding filter criteria for using grants/next API endpoint
  • Update SQL query to support filtering by only grants being followed by the current users team (user.agency_id). E.g.
    .whereIn(
      'grants.grant_id',
      knex.select('grant_id')
       .from('grant_followers')
       .join('users', 'users.id', 'grant_followers.user_id')
       .join('agencies', 'agencies.id', 'users.agency_id')
       .where('agencies.id', agencyId)
    )
    
    and returning a set of the teams (agencies table) following the grant in the same org/tenant (grant follower’ s user.tenant_id = current user’s tenant_id) to display in the table.
  • Update CSV export to support updated column label/values based on feature flag (route /grants/exportCSVNew)

Relevant Code Snippets

No response

@ClaireValdivia ClaireValdivia added the Grant Finder Issues related to the Grant Finder label Oct 8, 2024
@phm200 phm200 self-assigned this Oct 12, 2024
@phm200
Copy link
Contributor

phm200 commented Oct 13, 2024

@ClaireValdivia I assume the URL should reflect the new tab and new tab name when that tab is selected?

i.e.

  • "Shared With My Team" URL would be /my-grants/shared-with-my-team
  • "Followed by My Team" URL would be /my-grants/followed-by-my-team

@ClaireValdivia
Copy link
Contributor Author

@phm200 yes, thanks for catching that!

@phm200
Copy link
Contributor

phm200 commented Oct 19, 2024

rolling along here; need to make sure the wrap behavior is right:
Team name text should wrap if needed

and make sure the export csv is displaying the followed by data:
Update CSV export to support updated column label/values based on feature flag (route /grants/exportCSVNew)

hopefully get this up for review by end of weekend

@phm200
Copy link
Contributor

phm200 commented Oct 20, 2024

@ClaireValdivia should the changes to the Grants table, like renaming the "Interested Teams" column to "Followed By" also reflect in the main "Browse Grants" page? As well as the updated Export to CSV output? Or should these changes only be done to "My Grants" page?

I'm finishing up this PR and noticed in testing that the changes I made for "My Grants" page also reflect in "Browse Grants" and want to confirm if thats intended or not

@ClaireValdivia
Copy link
Contributor Author

@phm200 yes, confirming that the changes should reflect in the table on both the My Grants and Browse Grants pages.

And yes, the changes should be reflected in teh exports to csv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grant Finder Issues related to the Grant Finder
Projects
Status: 👀 In review
Development

No branches or pull requests

2 participants