Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Validation for DL / state ID #72

Open
embreinhardt opened this issue Apr 22, 2020 · 1 comment
Open

Validation for DL / state ID #72

embreinhardt opened this issue Apr 22, 2020 · 1 comment
Assignees
@mchin-cca
Labels
Backlog Don't work on these yet, but don't forget about them! priority:low

Comments

@embreinhardt
Copy link
Contributor

Screen Shot 2020-04-21 at 9 01 10 PM
@mchin-cca
Copy link
Contributor

Different states have different formats: https://ntsi.com/drivers-license-format/

Will keep this open as a reminder to implement on a state-by-state basis.

@mchin-cca mchin-cca self-assigned this Apr 23, 2020
@colinking colinking mentioned this issue Apr 24, 2020
Merged
colinking added a commit that referenced this issue Apr 28, 2020
@colinking
Add client-side validation for various form fields (#93)
f056d4b 
This PR adds client-side validation and formatting for:
- Integers: resolves #73)
- Decimals: resolves #73
- Dollar Amounts: resolves #73 (however, this will need an update after #77)
- shorttext + longtext
- date: resolves #69 (w/ new `min` and `max` validation fields)
- dropdown + singleselect
- multi-select
- boolean
- phone: resolves #15
- ssn: resolves #16
- state picker
- instructions-only
- arn

Some examples:

![image](https://user-images.githubusercontent.com/2907397/80447063-3f4e7100-88cd-11ea-974d-e0b51099e639.png)

![image](https://user-images.githubusercontent.com/2907397/80447072-44abbb80-88cd-11ea-9544-c6b86a9193ac.png)

It also cleans up some of the submission types (booleans submit as booleans not strings; phone numbers are integers; etc.).

It also adds regression testing, based on Alex's work, to the client for this validation.

After this PR, we'll still need validation for:
- address fields, but that's pending an update to how addresses are recorded with: #70
- files when that ships
- driver's licenses, depending on DL formats #72
@colinking colinking added the Backlog Don't work on these yet, but don't forget about them! label Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mchin-cca mchin-cca

Labels
Backlog Don't work on these yet, but don't forget about them! priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colinking @embreinhardt @mchin-cca