Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScrollViewer weirdly propagates its TemplatedParent to its Content #3762

Open
1 of 8 tasks
dr1rrb opened this issue Aug 10, 2020 · 3 comments
Open
1 of 8 tasks

ScrollViewer weirdly propagates its TemplatedParent to its Content #3762

dr1rrb opened this issue Aug 10, 2020 · 3 comments
Assignees
@MartinZikmund
Labels
area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...) triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified

Comments

@dr1rrb
Copy link
Member

dr1rrb commented Aug 10, 2020 •
edited
Loading

Current behavior

The ScrollViewer explicitly override the TemplatedParent of its Content in the ApplyScrollContentPresenterContent method.

If we remove this method, we might have a cyclic UI on iOS

Expected behavior

No patch

How to reproduce it (as minimally and precisely as possible)

Cf. linked bugs of #3738 and #3763 (When starting the Gallery project at commit 932e368, the app is stuck on the splashscreen on iOS)

Environment

Nuget Package: Uno.UI
Package Version(s): 3.0
Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Windows
  • Build tasks
  • Solution Templates
@dr1rrb dr1rrb added kind/bug Something isn't working triage/untriaged Indicates an issue requires triaging or verification labels Aug 10, 2020
@dr1rrb dr1rrb mentioned this issue Aug 10, 2020
Merged
6 tasks
@dr1rrb dr1rrb changed the title ScrollViewer weirdly propagates it TemplatedParent to its Content ScrollViewer weirdly propagates its TemplatedParent to its Content Aug 10, 2020
@francoistanguay francoistanguay modified the milestone: 3.1 Aug 28, 2020
@francoistanguay francoistanguay removed the triage/untriaged Indicates an issue requires triaging or verification label Aug 28, 2020
@francoistanguay francoistanguay modified the milestone: 3.1 Aug 29, 2020
@agneszitte agneszitte added the project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...) label Sep 21, 2020
@robloo robloo mentioned this issue Sep 22, 2020
Merged
6 tasks
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Jun 1, 2021
@MartinZikmund MartinZikmund changed the title ScrollViewer weirdly propagates its TemplatedParent to its Content ScrollViewer weirdly propagates its TemplatedParent to its Content Jun 14, 2023
@MartinZikmund MartinZikmund added platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer labels Jun 14, 2023
@MartinZikmund MartinZikmund added the triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified label Oct 9, 2024
@MartinZikmund
Copy link
Member

@morning4coffe-dev this may be fixed now with #17645 , can you check please?

@morning4coffe-dev
Copy link
Member

@MartinZikmund This seems to be iOS specific, do I have any way to test this without it?

@MartinZikmund
Copy link
Member

Not really, will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartinZikmund MartinZikmund

Labels
area/scrollviewer ⏬ Categorizes an issue or PR as relevant to ScrollViewer difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/bug Something isn't working platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform project/input ⌨️ Categorizes an issue or PR as relevant to input (Button, CheckBox, Toggle, Scroll, Map, Numeric,...) triage/potentially-fixed Categorizes an issue as potentially fixed by some unlinked PR, fix needs to be verified
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MartinZikmund @jeromelaban @dr1rrb @agneszitte @francoistanguay @morning4coffe-dev