Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependency to pyQuil v4 #2254

Open
cosenal opened this issue Apr 1, 2024 · 3 comments · May be fixed by #2063
Open

Upgrade dependency to pyQuil v4 #2254

cosenal opened this issue Apr 1, 2024 · 3 comments · May be fixed by #2063
Assignees
Labels
dependencies Pull requests that update a dependency file interface-and-conversions How Mitiq interfaces with quantum software packages. monitor-for-external-solution Tracking issues caused by external packages

Comments

@cosenal
Copy link
Contributor

cosenal commented Apr 1, 2024

If we still want to support pyQuil, then we also want to upgrade the pyQuil dependency v4, with the current version being pinned at pyquil~=3.5.4.

When it comes to the pyQuil integration, the benefits of upgrading are described in https://pyquil-docs.rigetti.com/en/stable/introducing_v4.html.

The main immediate benefit outside of the integration is that we could finally upgrade many transitive dependencies, see discussion in #2233 (comment)

Going from v3 to v4 in pyQuil carries some substantial breaking changes. I will use this ticket to track progress on the upgrade.

@cosenal cosenal added interface-and-conversions How Mitiq interfaces with quantum software packages. dependencies Pull requests that update a dependency file labels Apr 1, 2024
@cosenal cosenal self-assigned this Apr 1, 2024
@unitaryfund unitaryfund deleted a comment from github-actions bot Apr 1, 2024
@cosenal
Copy link
Contributor Author

cosenal commented Apr 1, 2024

@natestemen @nathanshammah If any of you has tried this before, please share your findings, including any branch with partial work.

@cosenal
Copy link
Contributor Author

cosenal commented Apr 1, 2024

First obstacle: the latest version of Cirq doesn't support pyQuil v4 https://github.com/quantumlib/Cirq/blob/7b97ead2a829f64cc9448122c89d03f887ee4fac/cirq-rigetti/requirements.txt

@natestemen
Copy link
Member

Thanks for opening this! Indeed there has been some work started in dependabot PR: #2063

As you saw, Cirq does not support pyQuil v4 and hence that is blocking, but they are working on it here: quantumlib/Cirq#6281! I've done a little bit to provide evidence that the PR is safe, but they need to resolve some tests on their end. It seems like they are trying to get this out in the next release, which is good news.

@cosenal cosenal added the monitor-for-external-solution Tracking issues caused by external packages label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file interface-and-conversions How Mitiq interfaces with quantum software packages. monitor-for-external-solution Tracking issues caused by external packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants