Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider: Prevent "no-op" calls to deposit altering functions? #69

Open
apbendi opened this issue Mar 15, 2024 · 0 comments
Open

Consider: Prevent "no-op" calls to deposit altering functions? #69

apbendi opened this issue Mar 15, 2024 · 0 comments

Comments

@apbendi
Copy link
Collaborator

apbendi commented Mar 15, 2024

We should check and revert if the user attempts to make a deposit related call that is effectively a no-op. This would include:

  • Staking 0 UNI
  • Adding 0 UNI to an existing deposit
  • Calling alter beneficiary with the same account
  • Calling alter delegatee with the same account
  • Withdrawing 0 UNI

This could help mitigate griefing attacks, but it's unclear it actually adds sufficient protection to be worthwhile. The attacker could still execute the attack extremely cheaply—gas costs remain by far the largest factor in dissuading such an attack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant