Cursor position goes back to previous clicked location when view Column selections are changed

[elsylambert]

Describe the bug
I. When I reach the bottom of a page, reviewing notes, and click the right arrowhead to turn the page, the cursor jumps to the top usually, but not always, maybe every fifth page or so, I have to push the curser up the slide myself.
II. If I click to turn on Quote for a quick look at the quote, the location jumps back to verse 1 (from verse 15). And if I click on Preview to see what the bolding actually looks like, my location in tN jumped from Proverbs 15:15 to 15:4

Steps to reproduce the behavior:

1. Go to en_tn/File. Scroll to the bottom of the page.
2. Click on right arrowhead to move over to next page, Cursor jumps to the top but sometimes, it does not.
3. From the header Menu> View columns> Check/Uncheck Columns
4. Note that cursor position moved few pages back.
5. Click on Preview button. Note that cursor position moved few pages back.

Expected behavior
Cursor position should be at the active row when columns added into view.

[RevantCI]

Hi @elsylambert
We reviewed the bug and code and found a few related issues and comments regarding the same workflow.

1. Jump to last clicked position after closing search #1088
2. Return to last clicked row on closing filter #1089
3. Jump to top of page after page forward navigation #1395
4. Maintain focus on row when changing what columns are visible. #1606
5. Changing from preview and back to editing loses the blue frame around the record  #1607
6. solved the issuses 1606, 1607 and 1395 #1614

Though we will just clear the doubts we had regarding it here.

Current workflow

1. If we click on a row to edit it, its position is saved
2. On clicking Preview/ changing columns / closing search it goes back to the clicked row
3. The above actions takes place irrespective of the current position. That is if its on the same page or if we navigate to other pages using the left and right arrow at the bottom page navigation menu

Proposed changed workflow

• one option could be if the user navigates to the next/previous page ( not during row search ) using the bottom page navigation arrows the last saved position in step 1 is reset to empty.

Else if you had another workflow in mind please let us know via the comments or we can have a call to discuss it.

Note: 2 of the above actions i.e. preview and clear search both navigate to the last clicked row and highlight it blue. The column change only navigates to the last clicked row but doesn't highlight it in blue. as per the comment in this PR.

[elsylambert]

@RevantCI The current workflow you mentioned is what we expect to happen.
Current workflow:

• If we click on a row to edit it, its position is saved- Last clicked position or the active row where the user is editing, that position is saved- works fine currently.
• On clicking Preview/ changing columns / closing search it goes back to the clicked row-
  **_- Only Clicking Preview goes back to last clicked position.
• Changing Columns goes back to last saved row/ not the last clicked position. BUG
• Closing Search does not go back to last clicked position. It stays at the beginning of the file. BUG_**
• The above actions takes place irrespective of the current position. That is if its on the same page or if we navigate to other pages using the left and right arrow at the bottom page navigation menu- If we are just navigating through the pages using right left arrows, that works fine as long as it is going back to last clicked position.

[RevantCI]

Hi @elsylambert
Both the bugs you had mentioned in your last comment are fixed and the datatable-translatable RCL is updated to 1.2.4 as per our call and in TC create the version has been bumped to the same 1.2.4.
Also as you had mentioned we have updated the version number of TC create itself to 1.17 for the release.

[elsylambert]

Thanks @RevantCI

[elsylambert]

Looks good in translationCore Create - v1.17 build 277-90c96ed.
Cursor positions stays on the active row when Preview is clicked, columns selections are changed or search is closed.