Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing a row it doesn't enable the save icon #1612

Open
Joel-C-Johnson opened this issue Aug 30, 2023 · 3 comments
Open

When removing a row it doesn't enable the save icon #1612

Joel-C-Johnson opened this issue Aug 30, 2023 · 3 comments

Comments

@Joel-C-Johnson
Copy link
Collaborator

Joel-C-Johnson commented Aug 30, 2023

Summary

In tC create when we remove a row it does not make any changes in the file. It's also not enabling the save icon. We can switch to a different file as there are no changes. It should pop a window showing files are changed

DoD

when we remove a row it should enable the save icon (that means there is an edit in the file) and click save the icon it should update the file in DCS.

@Joel-C-Johnson Joel-C-Johnson self-assigned this Aug 31, 2023
@Joel-C-Johnson
Copy link
Collaborator Author

This issue is solved. Details here unfoldingWord/datatable-translatable#140 (comment)

@elsylambert elsylambert added question Further information is requested and removed question Further information is requested labels Oct 3, 2023
@elsylambert
Copy link
Contributor

DatatableTranslatable v1.2.1. Verified in https://deploy-preview-140--datatable-translatable.netlify.app/#/DataTableWrapper. When a row is removed, Save button is enabled.

@danielklapp
Copy link

Agree that when deleting a row the save button is enabled. Tested with DatatableTranslatable v1.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants